set up next.js app and static build #157
Conversation
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
DaltheCow
force-pushed
the
implement-base-ui-app
branch
from
3c4bfe8 to
c23c674
Compare
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
There was a problem hiding this comment.
Pull Request Overview
This PR bootstraps a new Next.js app configured for static export, with client-side rendering via the "use client" directive to support MUI theming and CSS-in-JS.
- Adds TypeScript configuration and path aliases
- Introduces basic
layout.tsx,page.tsx, global and module CSS for styling - Sets up
next.config.tsfor static export, ESLint config, and project metadata (package.json, README, .gitignore)
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/tsconfig.json | TS compiler options for Next.js + path aliases |
| ui/next.config.ts | output: "export" for static site generation |
| ui/src/app/layout.tsx | Root layout with Google fonts and metadata |
| ui/src/app/globals.css | Global CSS variables and base styles |
| ui/src/app/page.tsx | Client-side page component with images and CTAs |
| ui/src/app/page.module.css | Scoped styles for page layout and theming |
| ui/package.json | Project name, scripts, dependencies |
| ui/README.md | Setup and usage instructions |
| ui/.gitignore | Standard ignores for node, Next.js, env files |
| ui/.eslintrc.json | ESLint setup for TS and Next.js |
Comments suppressed due to low confidence (1)
ui/package.json:2
- [nitpick] The project name "guidellm" is unclear—consider renaming it to something more descriptive or aligned with the repo purpose.
"name": "guidellm",
|
📦 Build Artifacts Available |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
Just a note here, but I'm looking into moving all of these things around. Namely, package.json, tsconfig.json and .eslintrc.json. Thinking about next.config.ts as well. Mostly just trying to figure out big picture which things would be better off living in the root and which things are better of staying nested in src/ui. Due to Next.js being a framework and having certain expectations, it appears that we can't be too freeform, but it looks very possible to move package.json/package-lock.json to the root and then tsconfig.json and .eslintrc.json and other future configs we will add are optional and I don't know if there is an explicit benefit to moving them out of src/ui. But also I think it is fine to and expresses the intentions of the repo a bit better. Next.js looks for things in certain places and I haven't yet figured out if next.config.ts should be moved to the root or not. You didn't request it, but I'm just trying to think all of this through for what makes sense. Regardless this will all work and is a little more complicated than I expected for a simple thing. |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
This is a starter next.js app set up for static builds (static site generation comes from output: 'export' in the next.config.ts). It uses the 'use client' directive to tell Next.js to treat everything as client side code in the page.tsx file meaning that most of the app won't be prerendered. This mirrors our set up since we use MUI theming and CSS in JS which require most of the app to be client code.